This document describes various guidelines to ensure consistency and quality across the GitLab frontend team.
Be wary of the limitations that come with using Hamlit.
When it comes to CSS, we use a utils-based CSS approach. GitLab has its own CSS utils which are packaged inside the
gitlab-ui project and can be seen in the repository or on UNPKG. Please favor using these before adding or using any SCSS classes.
When making API calls, we use GraphQL as the first choice. There are still instances where GitLab REST API is used such as when creating new simple HAML pages or in legacy part of the codebase, but we should always default to GraphQL when possible.
We use Apollo as our global state manager and GraphQL client. VueX is still in use across the codebase, but it is no longer the recommended global state manager. You should not use VueX and Apollo together, and should avoid adding new VueX stores whenever possible.
Working with our frontend assets requires Node (v12.22.1 or greater) and Yarn (v1.10.0 or greater). You can find information on how to install these on our installation guide.
As Frontend engineers, we strive to give users delightful experiences. We should always think of how this applies at GitLab specifically: a great GitLab experience means helping our user base ship their own projects faster and with more confidence when shipping their own software. This means that whenever confronted with a choice for the future of our department, we should remember to try to put this first.
We define three core values, Stability, Speed and Maintainability (SSM)
Although velocity is extremely important, we believe that GitLab is now an enterprise-grade platform that requires even the smallest MVC to be stable, tested and with a good architecture. We should not merge code, even as an MVC, that could introduce degradation, poor performance, confusion or generally lower our users expectations.
This is an extension of the core value that want our users to have confidence in their own software and to do so, they need to have confidence in GitLab first. This means that our own confidence in our software should be at the absolute maximum.
Users should be able to navigate through the GitLab application with ease. This implies fast load times, easy to find pages, clear UX and an overall sense that they can accomplish their goal without friction.
Additionally, we want our speed to be felt and appreciated by our developers. This means that we should put a lot of effort and thoughts into processes, tools and documentation that help us achieve success faster across our department. This benefits us as engineers, but also our users that end up receiving quality features at a faster rate.
GitLab is now a large, enterprise-grade software and it often requires complex code to give the best possible experience. Although complexity is a necessity, we must remain vigilant to not let it grow more than it should. To minimize this, we want to focus on making our codebase maintainable by encapsulating complexity. This is done by:
- Building tools that solve commonly-faced problems and making them easily discoverable.
- Writing better documentation on how we solve our problems.
- Writing loosely coupled components that can be easily added or removed from our codebase.
- Remove older technologies or pattern that we deem are no longer acceptable.
By focusing on these aspects, we aim to allow engineers to contain complexity in well defined boundaries and quickly share them with their peers.
Now that our values have been defined, we can base our goals on these values and determine what we would like to achieve at GitLab with this in mind.
- Lowest possible FID, LCP and cross-page navigation times
- Minimal page reloads when interacting with the UI
- Have as little Vue applications per page as possible
- Leverage Ruby ViewComponents for simple pages and avoid Vue overhead when possible
- Migrate away from VueX, but more urgently stop using Apollo and VueX together
- Remove jQuery from our codebase
- Add a visual testing framework
- Reduce CSS bundle size to a minimum
- Reduce cognitive overhead and improve maintainability of our CSS
- Improve our pipelines speed
- Build a better set of shared components with documentation
We have detailed description on how we see GitLab frontend in the future in Frontend Goals section
If you’re a first-time contributor, see Contribute to GitLab development.
When you’re ready to create your first merge request, or need to review the GitLab frontend workflow, see Getting started.
For a guided introduction to frontend development at GitLab, you can watch the Frontend onboarding course which provides a six-week structured curriculum.
You can find current frontend initiatives with a cross-functional impact on epics with the label frontend-initiative.
How we write frontend tests, run the GitLab test suite, and debug test related issues.
Reusable components with technical and usage guidelines can be found in our Pajamas Design System.
Read the frontend FAQ for common small pieces of helpful information.
Running into a Frontend development problem? Check out this guide to help resolve your issue.
For supported browsers, see our requirements.