- Scope of work done by a database reviewer
- How to apply for becoming a database reviewer
- Resources for database reviewers
- How to apply for becoming a database maintainer
- What to do if you feel overwhelmed
This page includes introductory material for new database reviewers.
If you are interested in getting an application update reviewed, check the database review guidelines.
Database reviewers are domain experts who have substantial experience with databases,
SQL, and query performance optimization.
A database review is required whenever an application update touches the database.
The database reviewer is tasked with reviewing the database specific updates and making sure that any queries or modifications will perform without issues at the scale of GitLab.com.
For more information on the database review process, check the database review guidelines.
Team members are encouraged to self-identify as database domain experts and add it to their team profile
projects: gitlab: - reviewer database
Assign the MR which adds your expertise to the
team.yml file to a database maintainer
or the Database Team’s Engineering Manager.
team.yml update is merged, the Reviewer roulette
may recommend you as a database reviewer.
As a database reviewer, join the internal
#database Slack channel and ask questions or discuss
database related issues with other database reviewers and maintainers.
There is also an optional database office hours call held bi-weekly, alternating between European/US and APAC friendly hours. You can join the office hours call and bring topics that require a more in-depth discussion between the database reviewers and maintainers:
You should also join the #database-labs Slack channel and get familiar with how to use Joe, the Slackbot that provides developers with their own clone of the production database.
Understanding and efficiently using
EXPLAIN plans is at the core of the database review process.
The following guides provide a quick introduction and links to follow on more advanced topics:
Finally, you can find various guides in the Database guides page that cover more specific topics and use cases. The most frequently required during database reviewing are the following:
- Migrations style guide for creating safe SQL migrations.
- Avoiding downtime in migrations.
- SQL guidelines for working with SQL queries.
Once a database reviewer feels confident on switching to a database maintainer,
they can update their team profile
projects: gitlab: - trainee_maintainer database
The first step is to a create a Trainee Database Maintainer Issue. Use and follow the process described in the ‘Trainee database maintainer’ template.
Similar to all types of reviews, unblocking others is always a top priority. Database reviewers are expected to review assigned merge requests in a timely manner or let the author know as soon as possible and help them find another reviewer or maintainer.
We are doing reviews to help the rest of the GitLab team and, at the same time, get exposed to more use cases, get a lot of insights and hone our database and data management skills.
If you are feeling overwhelmed, think you are at capacity, and are unable to accept any more
reviews until some have been completed, communicate this through your GitLab status by setting
:red_circle: emoji and mentioning that you are at capacity in the status text.